Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dependabot): ✨ use groups to group pull requests #144

Closed
wants to merge 3 commits into from

Conversation

CandiedCode
Copy link
Contributor

@CandiedCode CandiedCode commented Apr 23, 2024

This will limit the number of PR's that get open by allowing one PR to have multiple dependencies.

Generally minor and patch versions shouldn't include breaking changes if the dependencies are following semantic versioning. However, there are some dependencies that may introduce breaking changes in a minor release. (Looking at your torch). This means, there is a low probability that one PR that contains multiple dependencies will fail and manual intervention will be required.

Right now there are 4 PRs that are all patch version bumps and 2 PRs that are minor version bumps. This would reduce 6 pr's to 2.

This will limit the number of PR's that get open, so 1 PR can merge multiple dependencies.  Generally minor and patch versions shouldn't include breaking changes if the dependencies are following semantic versioning.  However, there are some dependencies that may introduce breaking changes in a minor release.  (Looking at your torch).
@chrisking
Copy link
Member

@CandiedCode wanted to give you a quick heads up after your open PRs, we're currently working 100% of time on getting our finishing touches on our non-OSS items ready for RSA but we will absolutely review this and get back to you ASAP. We really appreciate the care you put into these PRs and I'm looking forward to them landing !

@seanpmorgan
Copy link
Member

@CandiedCode appreciate the effort here, but I think we'll keep dependabot PRs w.r.t individual dependencies for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants